Page MenuHomePhabricator
Differential D8424

efl_ui_selection: give this event a better name
ClosedPublic
Actions

Authored by bu5hm4n on Mar 20 2019, 7:16 AM.

Details

Reviewers
segfaultxavi
Maniphest Tasks
T7476: efl: Rename duplicated event names
Commits
rEFLdecfca4f238f: efl_ui_selection: give this event a better name
Summary

this event does not get emitted when selection per se changes, it gets
emitted when the selection in the window manager changes. we should
prefix this even with that.

ref T7476
Depends on D8423

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 20 2019, 7:16 AM
Herald added a project: efl. · View Herald TranscriptMar 20 2019, 7:16 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Mar 20 2019, 7:16 AM
bu5hm4n added a child revision: D8425: eolian: enable event redef checking by default.
segfaultxavi added a subscriber: segfaultxavi.Mar 20 2019, 7:45 AM

What is the Window Manager's selection? I mean, what is the difference between EFL's selection the WM's selection?
To be sure, EFL's selection is what happens when you select text (shift+cursors) in a text entry, right?

bu5hm4n added a comment.Mar 20 2019, 7:56 AM

Right. And the window manager selection is the current active selection in one of the clients that are opened in the window manager. Which is something different ...

segfaultxavi accepted this revision.Mar 20 2019, 8:22 AM

Understood. Makes sense. This is a beta mixin anyway :)

This revision is now accepted and ready to land.Mar 20 2019, 8:22 AM
Closed by commit rEFLdecfca4f238f: efl_ui_selection: give this event a better name (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 20 2019, 8:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20799

View Options

src/lib/elementary/efl_ui_selection.eo

Loading...
View Options

src/lib/elementary/efl_ui_selection_manager.c

Loading...