Page MenuHomePhabricator

eolian: enable event redef checking by default
ClosedPublic

Authored by bu5hm4n on Mar 20 2019, 7:16 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 20 2019, 7:16 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Mar 20 2019, 7:16 AM
This comment was removed by bu5hm4n.

This can now be reviewed!

devilhorns resigned from this revision.Mar 20 2019, 10:53 AM
q66 requested changes to this revision.Mar 20 2019, 11:52 AM

You can't just eina_hash_add into nhash without checking !oobj because if you do and the entry is already present, that's undefined behavior for our hash implementation, so either keep the if or make them eina_hash_set

This revision now requires changes to proceed.Mar 20 2019, 11:52 AM
bu5hm4n updated this revision to Diff 20821.Mar 20 2019, 12:03 PM
bu5hm4n edited the summary of this revision. (Show Details)

update

q66 requested changes to this revision.Mar 20 2019, 12:15 PM

you still missed one

This revision now requires changes to proceed.Mar 20 2019, 12:15 PM

Maybe just try to use inline comments for once, it might be usefull...

bu5hm4n updated this revision to Diff 20823.Mar 20 2019, 12:26 PM

use less stupid API in eolian.

q66 accepted this revision.Mar 20 2019, 1:11 PM
This revision is now accepted and ready to land.Mar 20 2019, 1:11 PM
Closed by commit rEFLab30ff3f9bd8: eolian: enable event redef checking by default (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 21 2019, 2:34 AM
This revision was automatically updated to reflect the committed changes.