Page MenuHomePhabricator

efl_access: add test cases for reading_info_type_set/get API
ClosedPublic

Authored by shilpasingh on Mar 20 2019, 8:10 AM.

Details

Summary

Add test cases for efl_access_object_reading_info_type_set and efl_access_object_reading_info_type_get
APIs

Test Plan

Query the attributes using atspi_accessible_get_attributes in atspi_client, for the key value "reading_info_type",
above set information should be returned

Signed-Off By: Shilpa Singh shilpa.singh@samsung.com

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shilpasingh created this revision.Mar 20 2019, 8:10 AM
shilpasingh requested review of this revision.Mar 20 2019, 8:10 AM

formatting fixes

bu5hm4n requested changes to this revision.Mar 20 2019, 8:53 AM

Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?

This revision now requires changes to proceed.Mar 20 2019, 8:53 AM
jsuya added a comment.Mar 20 2019, 5:50 PM

HI, I recommend testing the initial value(maybe 0) in _type_set test , or change tests _type_set and _type_get to _type_set_get.

Made changes in test cases, but retaining two different test cases for two different APIs
to maintain uniformity with other test cases

In D8427#152237, @jsuya wrote:

HI, I recommend testing the initial value(maybe 0) in _type_set test , or change tests _type_set and _type_get to _type_set_get.

I am thinking to modify reading_info_type_get API to return value EFL_ACCESS_READING_INFO_TYPE_NAME|EFL_ACCESS_READING_INFO_TYPE_ROLE|EFL_ACCESS_READING_INFO_TYPE_DESCRIPTION|EFL_ACCESS_READING_INFO_TYPE_STATE as this should
be default value and not 0, what do you think?

This test case patch will be updated based on status of
https://phab.enlightenment.org/D8435

This test case patch will be updated based on status of
https://phab.enlightenment.org/D8435

The above patch has been updated to consider 0 reading_info type as well. hence we can take this test case patch as it is
with out any modification.

Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?

The test cases are different now, Please check.

bu5hm4n accepted this revision.Mon, Mar 25, 2:39 AM

Thank you!

This revision is now accepted and ready to land.Mon, Mar 25, 2:39 AM

The reason i did not review this earlier was, that there was a open question from you to jsuyu, can you next time clarify that his concerns have been met or they have been invalid, I did not want to land this before this questions have been addressed / clarified. Thank you :)

Closed by commit rEFL834219013d9e: efl_access: add test cases for reading_info_type_set/get API (authored by shilpasingh, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMon, Mar 25, 2:42 AM
This revision was automatically updated to reflect the committed changes.