Page MenuHomePhabricator

elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.
ClosedPublic

Authored by SanghyeonLee on Mar 21 2019, 1:21 AM.

Details

Summary

current code set the disable EINA_TRUE when disabled,
but once it was set diabled, it never changed EINA_FALSE even we set the orientation_mode_disable as FALSE.

Test Plan

we have test suite on legacy action, and previous patch was failed to pass the test case.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SanghyeonLee created this revision.Mar 21 2019, 1:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

SanghyeonLee requested review of this revision.Mar 21 2019, 1:21 AM

@zmike, we have some testsuite for this elm_object_orientation_mode_disabled_set and it fails after your refactoring of this method.
the code looks never change once it disabled in non-layout case, I think it need to be fixed like this.

also in line 1946,
it need to changed EFL_UI_LAYOUT_BASE_CLASS in my thought,
I'll update another patch for that.

bu5hm4n accepted this revision.Mar 21 2019, 2:20 AM
This revision is now accepted and ready to land.Mar 21 2019, 2:20 AM
Closed by commit rEFL7bb702b0df39: elm : fallback orientation_mode_disable_set legacy behavior to get true… (authored by SanghyeonLee, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 21 2019, 2:34 AM
This revision was automatically updated to reflect the committed changes.