Page MenuHomePhabricator

efl_access: if 0 is set as reading_info_type, remove existing reading_info
ClosedPublic

Authored by shilpasingh on Mar 21 2019, 1:42 AM.

Details

Summary

if 0 is set as reading_info_type, remove existing reading_info and
allow default reading info types (name, role, state and description)
to be read.
Do not set reading info again in reading_info_type_set API if new
value matches the old value.

Test Plan

If application does not set reading_info_type or set 0 reading_info_type,
All four reading info types of an accessible object should be read on highlight.

Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>

Diff Detail

Repository
rEFL core/efl
Branch
work2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10492
Build 8250: arc lint + arc unit
shilpasingh created this revision.Mar 21 2019, 1:42 AM
shilpasingh requested review of this revision.Mar 21 2019, 1:42 AM
kimcinoo requested changes to this revision.Mar 21 2019, 3:08 AM
kimcinoo added inline comments.
src/lib/elementary/efl_access_object.c
304

If user sets 0 for reading_info, this "reading_info_type" attribute need to be removed.
Or the screen-reader AT-client need to be change to set all types if "reading_info_type" has 0 length string value.
Because it does not make sense there is no reading on screen-reader when an object got highlight.

317

By default (without "reading_info_type" attribute) screen-reader AT-client has to read all reading information.
So this function could return 0 is user does not set any value, even though screen-reader AT-client reads all reading information.
Reading all types on screen-reader does not mean this returns all types by default.
If user sets reading info type using _efl_access_object_reading_info_type_Set, then _efl_access_object_reading_info_type_Get has to return same value.

This revision now requires changes to proceed.Mar 21 2019, 3:08 AM
shilpasingh retitled this revision from efl_access: update default value in reading_info_type_get API to efl_access: if 0 is set as reading_info_type, remove existing reading_info.
shilpasingh edited the summary of this revision. (Show Details)
shilpasingh edited the test plan for this revision. (Show Details)

updated based on review comments

kimcinoo accepted this revision.Mar 24 2019, 6:18 PM
This revision is now accepted and ready to land.Mar 24 2019, 6:18 PM
kimcinoo closed this revision.Mar 24 2019, 6:18 PM