Page MenuHomePhabricator

efl_scroll: do not eat wheel events
AbandonedPublic

Authored by bu5hm4n on Mar 24 2019, 5:53 AM.

Details

Summary

when the scrollable interface is frozen or on hold, then no property is
changed anyways. Hence we can head out before doing the calculations.
Additionally, when we are not frozen or on hold, then we should mark the
mouse wheel event as used.

ref T2529

Depends on D8455

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10548
bu5hm4n created this revision.Mar 24 2019, 5:53 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Mar 24 2019, 5:53 AM

Can you explain how can I verify this patch? What is the problem being fixed?
Looks like an optimization PLUS an event was missing?

Just take a look into the referenced task

start elm_config go to the scroll side with the many sliders, and scroll there.

And its actaully a bug fix ... :)

OK, got it. Using the scrollwheel on a scroller full of sliders is still a dangerous business, but it makes a bit more sense this way.
I cannot review the changes, though, you should add some reviewers :)

bu5hm4n updated this revision to Diff 20931.Mar 25 2019, 9:37 AM
bu5hm4n edited the summary of this revision. (Show Details)

here comes a test

bu5hm4n abandoned this revision.Mar 26 2019, 2:34 AM

This is not needed, the other revision is enough. This here would have been a nice addition since less things are calculated. However, it causes issues. so lets abond this for now, and lets go ahead with the other revision.