Page MenuHomePhabricator

elementary: embed standard config as fallback
ClosedPublic

Authored by bu5hm4n on Mar 26 2019, 10:09 AM.

Details

Summary

as you can see in T7620, there is quite some critics about how we are
handling configs in elm. This patch enables the compile-time standard
config to be used instead of some weak-wrong-usage hardcoded structure
defines somewhere in elm.

This means, that every update to the default theme will be also in the
next build embedded, without any config files installed at all, the
standard config for desktops will work, and a error will be printed, so
the user does have the possibility to interact with elm as he wishes,
while he sees this error.

fixes T7620

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 26 2019, 10:09 AM
bu5hm4n requested review of this revision.Mar 26 2019, 10:09 AM

@zmike, can you give me a tip how to do that for autotools ?

devilhorns requested changes to this revision.Mar 26 2019, 10:31 AM
devilhorns added a subscriber: devilhorns.
devilhorns added inline comments.
src/lib/elementary/elm_config.c
1759

Instead of "found / created" , can we use "found or created" ?? I think that will translate better (ie: read better) in other languages for po files.

This revision now requires changes to proceed.Mar 26 2019, 10:31 AM
bu5hm4n added inline comments.Mar 26 2019, 10:52 AM
src/lib/elementary/elm_config.c
1759

That is an error message there is no po translation for this ...

bu5hm4n updated this revision to Diff 20965.Mar 26 2019, 11:00 AM
bu5hm4n edited the summary of this revision. (Show Details)

reintroduce accidently commented out code.

devilhorns added inline comments.Mar 26 2019, 11:05 AM
src/lib/elementary/elm_config.c
1759

Ahh yes, you are correct. I was confusing fprintf error translations :/ Still, I think it reads better with an "or" anyway...

zmike accepted this revision.Mar 27 2019, 2:18 PM

This is fine to go in with D8489

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2019, 2:23 PM
Closed by commit rEFLf04cc5ceba13: elementary: embed standard config as fallback (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain Why
This revision was automatically updated to reflect the committed changes.