Page MenuHomePhabricator

mono: fix space and brace warnings of StyleCop
ClosedPublic

Authored by Jaehyun_Cho on Mar 27 2019, 3:05 AM.

Details

Summary

The following warning rules of StyleCop are checked.
Space rules : SA1000, SA1003, SA1008, SA1009, SA1010, SA1011
Brace rules : SA1500, SA1501, SA1502, SA1503, SA1513

Indentation is also applied.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jaehyun_Cho created this revision.Mar 27 2019, 3:05 AM
Jaehyun_Cho requested review of this revision.Mar 27 2019, 3:05 AM

I am not sure which is better either 1. apply 4 spaces indentation inside each namespace or 2. do not apply it (which is current patch).

There is no space/brace warning on the above both ways.

Jaehyun_Cho retitled this revision from mono: fix space and brace warnings from StyleCop to mono: fix space and brace warnings of StyleCop.Mar 27 2019, 3:44 AM
Jaehyun_Cho edited the summary of this revision. (Show Details)

I am not sure which is better either 1. apply 4 spaces indentation inside each namespace or 2. do not apply it (which is current patch).

There is no space/brace warning on the above both ways.

Does StyleCop have any rule regarding namespace indentation? I'd prefer keeping no spaces.

I prefer no namespace indentation in any language whatsoever.
I really hope that no C# style analysis tool enforces it.

removed namespace indentation in efl_csharp_application.cs

@lauromoura @vitor.sousa

There is no indentation rule on StyleCop but normally indentation is automatically applied when I type inside the namespace bracket.
So I was not sure which way is better.

Based on your opinions, I did not apply indentation for namespace and I removed indentation for namespace in efl_csharp_application.cs as well to synchronize other cs files.

This revision is now accepted and ready to land.Apr 1 2019, 11:23 AM
This revision was automatically updated to reflect the committed changes.