Page MenuHomePhabricator

elc_filselector: solve the mysterium of sometimes failing tests
ClosedPublic

Authored by bu5hm4n on Mar 27 2019, 1:22 PM.

Details

Summary

so after a phone call, two days of debugging, tears, crying etc. etc. we
finally came to a point of enlightenment! *Someone* (bu5hm4n) moved
gengrid and genlist events from eo back to smart events, so we can work
arround legacy borks and event-name collisions, at this point he did not
knew that some widgets (fileselector) already relied on those *lovely*
events. Hence this broke theoretically the testsuite, however, the
fileselector testsuite is ultimatily buggy, and the wait function does
not return false when it timeouts, (i don't know why not). So this break
was never discovered.

Additionally there is a second issue. it appears, that when we
immidiatly quit the mainloop after we have got the selected callback,
that then genlist decides to forget about the sd->selected pointer, and
NULLs that one out. Which then results in the fact that
elm_fileselector_selected_get ends up returning invalid paths.
Depends on D8450

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 27 2019, 1:22 PM
bu5hm4n requested review of this revision.Mar 27 2019, 1:22 PM
cedric accepted this revision.Mar 27 2019, 2:47 PM
This revision is now accepted and ready to land.Mar 27 2019, 2:47 PM
Closed by commit rEFL197210cde2bc: elc_filselector: solve the mysterium of sometimes failing tests (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain WhyMar 27 2019, 3:07 PM
This revision was automatically updated to reflect the committed changes.