Page MenuHomePhabricator

efl_check: add API to expect a error
ClosedPublic

Authored by bu5hm4n on Apr 1 2019, 6:02 AM.

Details

Summary

sometimes it is not enough to just disable aborting on critical error
messages. Sometimes it is better to explicitly expect an error, and fail
the testcase if there is no error.

This is used in later commits here.

Depends on D8417

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Apr 1 2019, 6:02 AM
zmike requested changes to this revision.Apr 1 2019, 6:06 AM

Probably you don't want to name the variable error as this is likely to trigger shadow warnings.

This revision now requires changes to proceed.Apr 1 2019, 6:06 AM
bu5hm4n updated this revision to Diff 21109.Apr 1 2019, 6:29 AM
bu5hm4n edited the summary of this revision. (Show Details)

review comments

bu5hm4n updated this revision to Diff 21113.Apr 1 2019, 9:20 AM

Review Comments

zmike accepted this revision.Apr 2 2019, 5:53 AM
This revision is now accepted and ready to land.Apr 2 2019, 5:53 AM
Closed by commit rEFLde8993575c0a: efl_check: add API to expect a error (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyApr 2 2019, 5:58 AM
This revision was automatically updated to reflect the committed changes.