Page MenuHomePhabricator

efl_io_model: start early on monitoring
ClosedPublic

Authored by bu5hm4n on Apr 1 2019, 8:34 AM.

Details

Summary

Little introduction into what eio did before this commit:
Efl.Io.Model creation:

  • direct ls of a directory in a thread (A)
  • take all the contents of a directory and feed it slowly back into

the mainloop

  • when all events have been feeded back to the mainloop and have been

processed: start monitoring (B)

However, any file created between (A) and (B) will not be in the model,
since not the listing nor the monitoring did caputure it. Hence we need
to start monitoring before we actaully start listing. In the callbacks
we then check if we already published something.

ref T7311

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Apr 1 2019, 8:34 AM
bu5hm4n requested review of this revision.Apr 1 2019, 8:34 AM

It does not fix the issue on travis-ci. I am still have way sure that this is a valid bugfix ...

cedric accepted this revision.Apr 1 2019, 9:27 AM
This revision is now accepted and ready to land.Apr 1 2019, 9:27 AM
Closed by commit rEFLc29dae34a0b8: efl_io_model: start early on monitoring (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyApr 2 2019, 5:51 AM
This revision was automatically updated to reflect the committed changes.