Page MenuHomePhabricator

add builtin lround() check if it is not in libm
Needs RevisionPublic

Authored by vtorri on Apr 2 2019, 10:41 PM.

Details

Summary

autotools check for builtin lround() if not in libm

Test Plan

configuration

Diff Detail

Repository
rEFL core/efl
Branch
vtorri_lround
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10732
Build 8347: arc lint + arc unit
vtorri created this revision.Apr 2 2019, 10:41 PM
vtorri requested review of this revision.Apr 2 2019, 10:41 PM
bu5hm4n added a subscriber: bu5hm4n.Apr 3 2019, 1:44 AM

You can just remove the header checks, the additions are not required, lround is used without the check for HAVE_LROUND anyways.

bu5hm4n requested changes to this revision.Apr 3 2019, 1:45 AM
This revision now requires changes to proceed.Apr 3 2019, 1:45 AM
vtorri added a comment.Apr 3 2019, 5:16 AM

git grep HAVE_LROUND :

src/lib/evas/include/evas_common_private.h:#ifndef HAVE_LROUND

Yes, and still there are cases in eina quad and efl_wl. Which would have caused the compilation to abort. So this check is unnecessary, we can drop this part of code in the header I guess.

vtorri added a comment.Apr 3 2019, 6:15 AM

actually, __builtin_lround() is not used at all in the code ,afaics

vtorri added a comment.Apr 3 2019, 8:44 PM

maybe actually this diff should be abandoned and i should remove the test in configure.ac about __builtin_lround ?

I would say so yes, in general the header checks etc. in meson are most of the time only migrated when they are really used in code.