Page MenuHomePhabricator

efl-mono: Make override of methods only for methods that are defined by the user
ClosedPublic

Authored by felipealmeida on Apr 8 2019, 3:49 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
felipealmeida created this revision.Apr 8 2019, 3:49 PM
felipealmeida requested review of this revision.Apr 8 2019, 3:49 PM
lauromoura accepted this revision.Apr 8 2019, 5:43 PM
This revision is now accepted and ready to land.Apr 8 2019, 5:43 PM
This revision was automatically updated to reflect the committed changes.

I think this commit added a lot of warnings because the methods variable is not always needed:

public override System.Collections.Generic.List<Efl_Op_Description> GetEoOps(System.Type type)
{
    var descs = new System.Collections.Generic.List<Efl_Op_Description>();
    var methods = Efl.Eo.Globals.GetUserMethods(type);
    descs.AddRange(base.GetEoOps(type));
    return descs;
}
...
src/bindings/mono/efl_ui_legacy.eo.cs(111,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_button_legacy_part.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_radio_legacy_part.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_check_legacy_part.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_progressbar_legacy_part.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_image_zoomable_pan.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
src/bindings/mono/efl_ui_text_part.eo.cs(66,13): warning CS0219: The variable `methods' is assigned but its value is never used
Compilation succeeded - 43 warning(s)