Page MenuHomePhabricator

efl-mono: Allow generating doc refs for methods without class
ClosedPublic

Authored by segfaultxavi on Apr 9 2019, 6:37 AM.

Details

Summary

Methods without a class (global) make the previous code crash because
func.klass contains something (it cannot be NULL because it is a reference)
but you cannot make much calls on this something.

Test Plan

Currently there are no such references, but I need this working for upcoming patches.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.Apr 9 2019, 6:37 AM
segfaultxavi requested review of this revision.Apr 9 2019, 6:37 AM

Fix previous git mess

segfaultxavi added inline comments.Apr 9 2019, 6:43 AM
src/bin/eolian_mono/eolian/mono/documentation.hh
107

@lauromoura any idea why this was being done in such a convoluted way?
I don't see the need for the temporary klass (and it crashes).

vitor.sousa added inline comments.
src/bin/eolian_mono/eolian/mono/documentation.hh
107

It seems to be a copy-paste overlook.
Aparently, removing it is the best, indeed.

vitor.sousa accepted this revision.Apr 10 2019, 1:52 PM

Everything looks fine IMHO.

This revision is now accepted and ready to land.Apr 10 2019, 1:52 PM
This revision was automatically updated to reflect the committed changes.