Page MenuHomePhabricator

efl-mono: Allow doc XML tags to be nested
ClosedPublic

Authored by segfaultxavi on Apr 9 2019, 10:38 AM.

Details

Summary

This allows inserting nested tags like:
<example><code>bla bla bla</code></example>

The generate_tag_example() is currently unused but serves as an example.

Depends on D8585

Test Plan

Not much, unless you want to manually call generate_tag_example()
(Which I have done, and it works, I promise).

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.Apr 9 2019, 10:38 AM
segfaultxavi requested review of this revision.Apr 9 2019, 10:38 AM
lauromoura added inline comments.Apr 9 2019, 12:04 PM
src/bin/eolian_mono/eolian/mono/documentation.hh
249

Wouldn't this generate the scope tab "twice" when starting the docs? One from line 284 and another from this line?

288

Shouldn't this \n be without a scope tab?

Remove lots of unnecessary tabs.

segfaultxavi marked 2 inline comments as done.Apr 10 2019, 1:54 AM

Thanks @lauromoura !

vitor.sousa requested changes to this revision.Apr 10 2019, 12:10 PM
vitor.sousa added a subscriber: vitor.sousa.

Very good. Just a note:

src/bin/eolian_mono/eolian/mono/documentation.hh
284

Missing return false at the end.

318

ditto

This revision now requires changes to proceed.Apr 10 2019, 12:10 PM

Add missing return statements

segfaultxavi marked 2 inline comments as done.Apr 10 2019, 12:54 PM

Ouch! Thanks!

Everything seems OK to me now.

vitor.sousa accepted this revision.Apr 10 2019, 1:43 PM
This revision is now accepted and ready to land.Apr 10 2019, 1:43 PM
This revision was automatically updated to reflect the committed changes.