Page MenuHomePhabricator

efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface
AbandonedPublic

Authored by jsuya on Apr 11 2019, 12:17 AM.

Details

Reviewers
Hermet
smohanty
Summary

The coordinate system of a gradient can have several properties.
We can specify properties that follow the current coordinate system
and follow the bounding box.
This interface to store and manage its properties in the gradient class.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10870
Build 8451: arc lint + arc unit
jsuya created this revision.Apr 11 2019, 12:17 AM
jsuya requested review of this revision.Apr 11 2019, 12:17 AM
jsuya planned changes to this revision.Apr 11 2019, 1:13 AM
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_gfx_gradient.eo
39

You can use @Efl.Gfx.Gradient_Units.object_bounding_box to obtain a linked reference.

43

Is the comment correct?

src/lib/efl/interfaces/efl_gfx_types.eot
83

Specifies the coordinate system for position attributes.

85

Should be @since 1.23, no?

jsuya updated this revision to Diff 21380.Apr 16 2019, 7:27 PM

Update code :)

jsuya marked 4 inline comments as done.Apr 16 2019, 7:36 PM

thank you for review

Hermet requested changes to this revision.Apr 17 2019, 6:18 PM

Still, I'm skeptic at this since this might increase complexity,

  1. Why *Only* gradient should support this?
  2. What happens if user change the unit without any coordinate values?
  3. If it's necessary, then how about cairo, android, skia handle this?
This revision now requires changes to proceed.Apr 17 2019, 6:18 PM
jsuya abandoned this revision.Apr 18 2019, 6:53 PM