Page MenuHomePhabricator

csharp: Simple spacing rules changes
ClosedPublic

Authored by lauromoura on Apr 15 2019, 2:20 PM.

Details

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Apr 15 2019, 2:20 PM
lauromoura requested review of this revision.Apr 15 2019, 2:20 PM
segfaultxavi requested changes to this revision.Apr 16 2019, 2:14 AM

Much nicer, but there is still some non-perfect whitespace:
If you search for ///< (without separating space) in klass.h and struct_definition.hh you can find many places.

src/bin/eolian_mono/eolian/mono/documentation.hh
265

This does not prevent empty tags. You have to put this same check in line 288, inside generate_tag().

This revision now requires changes to proceed.Apr 16 2019, 2:14 AM

Much nicer, but there is still some non-perfect whitespace:
If you search for ///< (without separating space) in klass.h and struct_definition.hh you can find many places.

Yeah. These are the hardcoded ones that will be dealt with in future patches.

lauromoura updated this revision to Diff 21371.Apr 16 2019, 6:15 AM

Update moving check for empty string to root generate_tag.

lauromoura marked an inline comment as done.Apr 16 2019, 6:15 AM
segfaultxavi accepted this revision.Apr 16 2019, 6:46 AM
This revision is now accepted and ready to land.Apr 16 2019, 6:46 AM
vitor.sousa accepted this revision.Apr 16 2019, 8:03 AM
This revision was automatically updated to reflect the committed changes.