Page MenuHomePhabricator

ui.table: remove leagcy evas_table from Efl.Ui.Table
ClosedPublic

Authored by YOhoho on Mon, Apr 15, 9:25 PM.

Details

Summary

Remove evas_table.
This expect to improve performance by removing internal function call related
evas_table.

Test Plan
  • make check
  • elementary_test -to 'efl.ui.table'
  • elementary_test -to 'efl.ui.table (linear api)'

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Mon, Apr 15, 9:25 PM
YOhoho requested review of this revision.Mon, Apr 15, 9:25 PM

Hi, there have been 3 revisions for table, where the last one is at https://phab.enlightenment.org/D8556 would you be so kind and base this work on top of them? :)

Hi, there have been 3 revisions for table, where the last one is at https://phab.enlightenment.org/D8556 would you be so kind and base this work on top of them? :)

Oh, yes.

Thank you :)

YOhoho updated this revision to Diff 21401.Wed, Apr 17, 3:05 AM
YOhoho edited the summary of this revision. (Show Details)

rebase

bu5hm4n requested changes to this revision.Wed, Apr 17, 11:00 PM

This does not pass the new efl_ui_spec testsuite, can you check that out ?

ninja test does execute it.

This revision now requires changes to proceed.Wed, Apr 17, 11:00 PM
YOhoho updated this revision to Diff 21448.Thu, Apr 18, 1:22 AM
YOhoho edited the summary of this revision. (Show Details)

Nice test!

bu5hm4n accepted this revision.Sun, Apr 21, 3:08 AM
This revision is now accepted and ready to land.Sun, Apr 21, 3:08 AM
Closed by commit rEFL3e495010431e: ui.table: remove leagcy evas_table from Efl.Ui.Table (authored by YOhoho, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhySun, Apr 21, 3:13 AM
This revision was automatically updated to reflect the committed changes.