Page MenuHomePhabricator

ui.relative_layout: enhance relation_xxx_set,get apis
ClosedPublic

Authored by YOhoho on Apr 17 2019, 12:46 AM.

Details

Summary

I forgot efl_pack_layout_request after relation_xxx is changed.
Unnecessary register function in relation_xxx_get will return unexpected result.
if a object is not child of relative_layout, relation_xxx_get should return
target = NULL and relative = 0.0 with error message.

Test Plan

make check

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Apr 17 2019, 12:46 AM
YOhoho requested review of this revision.Apr 17 2019, 12:46 AM
YOhoho updated this revision to Diff 21560.Apr 23 2019, 5:41 AM

replace with EINA_DBL_EQ.

YOhoho updated this revision to Diff 21590.Apr 23 2019, 10:28 PM

more unit test

Jaehyun_Cho accepted this revision.Wed, Apr 24, 4:22 AM
This revision is now accepted and ready to land.Wed, Apr 24, 4:22 AM
Closed by commit rEFL8c0ab0db4255: ui.relative_layout: enhance relation_xxx_set,get apis (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by Jaehyun_Cho). · Explain WhyWed, Apr 24, 5:02 AM
This revision was automatically updated to reflect the committed changes.