Page MenuHomePhabricator

csharp: refactor native_inherit into a nested class.
ClosedPublic

Authored by lauromoura on Apr 17 2019, 2:57 PM.

Details

Summary

Efl.Ui.Button_NativeInherit -> Efl.Ui.Button.NativeMethods

Will help using EFL# with completion tools.

  • Added pragmas around the native function definitions to avoid warnings related to the name of native functions
  • Updated some style fixes for native function wrappers.

Their preamble and epilogue styling will be dealt with in future diffs.

As a side effect, concrete classes had to be made public again as they
hold the function pointers to the native methods of their interfaces.
Thus a third party library class that implements IFoo should be able to
access these methods.

Fixes T7743

Depends on D8622

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Apr 17 2019, 2:57 PM
lauromoura requested review of this revision.Apr 17 2019, 2:57 PM
vitor.sousa added inline comments.Apr 18 2019, 3:00 PM
src/bin/eolian_mono/eolian/mono/function_definition.hh
58

s/what/that/ ?

lauromoura updated this revision to Diff 21539.Mon, Apr 22, 2:28 PM

Rebase and fix comment.

lauromoura marked an inline comment as done.Mon, Apr 22, 2:29 PM
vitor.sousa accepted this revision.Mon, Apr 22, 2:59 PM
This revision is now accepted and ready to land.Mon, Apr 22, 2:59 PM
segfaultxavi accepted this revision.Tue, Apr 23, 2:57 AM

Does as advertised, passes tests and build examples.

This revision was automatically updated to reflect the committed changes.