Page MenuHomePhabricator

eio: rely on inheritance and reflection for Efl.IoModel path property.
ClosedPublic

Authored by cedric on Apr 18 2019, 4:23 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Apr 18 2019, 4:23 PM

Mhm not really a blocker for merging this, but before this is not very performance intensitive. After that this is a list search on a lot of properties. Do you think this might hamper performance ?

bu5hm4n requested changes to this revision.Sat, Apr 20, 5:55 AM

I request changes for now, so its out of the loop.

This revision now requires changes to proceed.Sat, Apr 20, 5:55 AM

Mhm not really a blocker for merging this, but before this is not very performance intensitive. After that this is a list search on a lot of properties. Do you think this might hamper performance ?

It shouldn't. If it does, we can always improve things later with a tree search especially for reflected property. I am more into improving the speed of the least amount of code than trying to have custom unnecessary code.

bu5hm4n accepted this revision.Sun, Apr 21, 1:49 AM

True.

This revision is now accepted and ready to land.Sun, Apr 21, 1:49 AM
Closed by commit rEFL3b0261d5524a: eio: rely on inheritance and reflection for Efl.IoModel path property. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhySun, Apr 21, 2:37 AM
This revision was automatically updated to reflect the committed changes.