Page MenuHomePhabricator

ecore: properly handle CHILD_ADDED and CHILD_REMOVED from source for Efl.CompositeModel
ClosedPublic

Authored by cedric on Apr 18 2019, 4:35 PM.

Details

Summary

Before this patch we were directly sending this event on the Efl.CompositeModel, but they
actually might contain an Efl.Model in the event child field. That Efl.Model wouldn't have
been converted before to an Efl.CompositeModel exposing incoherence from the user of
the object point of view. This patch fix that behavior.
Depends on D8660

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Apr 18 2019, 4:35 PM
cedric requested review of this revision.Apr 18 2019, 4:35 PM
bu5hm4n accepted this revision.Thu, Apr 25, 4:53 AM
This revision is now accepted and ready to land.Thu, Apr 25, 4:53 AM

I have this patch and the previous one properly updated, but I can't get phab to update it without failing in the middle. Once the first patches of the series are accepted, I can land all of it.

This revision was automatically updated to reflect the committed changes.