Page MenuHomePhabricator

Revert "remove vpath test for user dir the test was broken and fixing is insane"
ClosedPublic

Authored by bu5hm4n on Sun, Apr 21, 12:03 PM.

Details

Summary

This reverts commit 954a534bc0e7f30e66cc7dfd15ac79544e92671f.

It appears that the concerns from this commit are invalid. The case of
~asdf/ does not have any fallback case, if there is no getpwent on this
system, then there will be simply an error, same for the case of a
missing user. In such a case nothing will be written in the buffer /
returned by eina_vpath. The windows build problem can be
fixed by a simple #ifdef'ing the test code.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Sun, Apr 21, 12:03 PM
bu5hm4n requested review of this revision.Sun, Apr 21, 12:03 PM
zmike added a comment.Fri, May 3, 6:43 AM

So then maybe you should also add the ifdef for fixing the Windows issue before this lands?

Windows does not have getpwent, thats the issue. If windows one day serves getpwuid, then this is automatically working again ... :)

vtorri added a subscriber: vtorri.Wed, May 15, 6:20 AM

getuid does not exist on Windows, so i guess that you should add another guard

getuid must be on a platform that supports getpwuid, otherwise there is no way of getting the id...

vtorri accepted this revision.Wed, May 15, 6:45 AM

ok, though there is a getpwuid in Evil
anyway, this code will not be compiled on Windows, so fine for me

This revision is now accepted and ready to land.Wed, May 15, 6:45 AM
Closed by commit rEFLf417fb26e88c: Revert "remove vpath test for user dir the test was broken and fixing is insane" (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyWed, May 15, 6:50 AM
This revision was automatically updated to reflect the committed changes.