- Add "Animation View" item at elementary_main.
- Change EAPIs naming.
- Change version 1.22 to 1.23.
Details
Details
- Reviewers
Hermet kimcinoo segfaultxavi
make doc
firefox doc/html/widgetslist.html
Go "Animation View"
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- devs/hermet/lottie
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10976 Build 8519: arc lint + arc unit
| src/lib/elementary/efl_ui_animation_view.eo | ||
|---|---|---|
| 37 | This comment is not related to your change. | |
Comment Actions
Thanks for adding this to the EO docs!
However, this patch does not apply on top of current master (file efl_ui_animation_view.eo does not exist). Can you rebase it?
| src/lib/elementary/efl_ui_animation_view.eo | ||
|---|---|---|
| 24 | The end of this line is missing! | |
| 25 | I don't think we need to list the events here. There should be an events section in the EO file with these docs. | |
| 52 | Please do not add BOTH property AND set/get docs. Only one will be used. | |
Comment Actions
Hi @segfaultxavi
This patch is working on devs/hermet/lottie branch.
@Hermet is preparing features related to this patch.
Thank you for your help.
| src/lib/elementary/efl_ui_animation_view.eo | ||
|---|---|---|
| 24 | Thanks i will fix soon. | |
| 25 | I know, We should add and implement events in event section. I will delete this list. | |
| 52 | sorry i dont understand your comment [src/lib/elementary/efl_ui_animation_view.eo.h] /** * @brief Animation will be started automatically when it's possible. * * If @ref efl_ui_animation_view_auto_play_get is @c true, animation will be * started when it's readied. The condition of @c auto play is when animation * view opened file successfully, yet to play it plus when the object is * visible. If animation view is disabled, invisible, it turns to pause state * then resume animation when it's visible again. * * @warning This auto play will be only affected to the next animation source. * So must be called before setting animation file * * Set auto play mode of an animation view object. @c true Enable auto play * mode, disable otherwise * * @param[in] obj The object. * @param[in] auto_play Auto play mode, Default value is @c false * * @since 1.23 * * @ingroup Efl_Ui_Animation_View */ EOAPI void efl_ui_animation_view_auto_play_set(Eo *obj, Eina_Bool auto_play); /** * @brief Animation will be started automatically when it's possible. * * If @ref efl_ui_animation_view_auto_play_get is @c true, animation will be * started when it's readied. The condition of @c auto play is when animation * view opened file successfully, yet to play it plus when the object is * visible. If animation view is disabled, invisible, it turns to pause state * then resume animation when it's visible again. * * @warning This auto play will be only affected to the next animation source. * So must be called before setting animation file * * Returns auto play mode of an animation view object. * * @param[in] obj The object. * * @return Auto play mode, Default value is @c false * * @since 1.23 * * @ingroup Efl_Ui_Animation_View */ EOAPI Eina_Bool efl_ui_animation_view_auto_play_get(const Eo *obj); | |
| src/lib/elementary/efl_ui_animation_view.eo | ||
|---|---|---|
| 52 | Yeah, but unfortunately this does not happen for the C# docs. | |
Comment Actions
I cannot close this revision because I could not change status to 'accepted'
But it was possible 'git push' this change. Probably @segfaultxavi needs to accept this.
Comment Actions
I guess I will review this again when it tries to go to master. It wasn't my intention to review something still in a development branch. Sorry for interrupting!
Comment Actions
@segfaultxavi
This patch has been merged into devs/hermet/lottie branch before updating the fix you requested.
I will update your request with new patches.
Thank you for reviewing :)