elm_scroller_loop_set cannot be used for other widgets except scroller,
the API should be generic as this functionality can be implemented by other widgets as well.
Details
test looping functionality by calling elm_scroller_loop_set
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
I am wondering a bit about this revision. This is a legacy API, shouldn't something like this be used in the new scroller class ? Otherwise this feature will be gone and or unable to be used on new widgets.
Additionally, the definition of the actual header API is missing.
we already have a legacy API elm_scroller_loop_set but this API has not been implemented in a generic manner, that means I cannot call elm_scroller_loop_set on widgets like genlist, toolbar etc.
this change will make sure elm_scroller_loop_set becomes a generic API.
This API will work like policy_set, page_size_set, bounce_set APIs, these are not yet added as part of efl_ui_scroller.c
Legacy API itself is enhanced to be generic currently, in future when all the above legacy APIs are ported, then loop_set/get also will get ported but as a generic API
now calling elm_scroller_loop_set on say genlist will cause crash. Looping mechanism can be widget specific, every scrollable widget might implement its own looping mechanism like genlist then
a call elm_scroller_loop_set(genlist, ...); should work successfully.
Also as elm_scroller.eo is already removed, I added the required changes in elm_scroller.eo.c directly
@bu5hm4n Please reply to my comment so that I can take appropriate action and raise an updated patch
This looks fine i guess. I got distracted by something else. Sorry.
For further revisions: If you disagree with the reviewers comment, then you can set the revision into the state "Request Review" then it will again show up in the filter for revision that need attention.