Page MenuHomePhabricator

entry: revert a single line
AbandonedPublic

Authored by akanad on Apr 23 2019, 9:34 PM.

Details

Reviewers
zmike
bu5hm4n
Summary

the line this patch is reverting was not I intended.
at D8362, I just wanted to accept what zmike proposed.
this patch make the previous patch what It was supposed to be.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11003
Build 8532: arc lint + arc unit
akanad created this revision.Apr 23 2019, 9:34 PM
akanad requested review of this revision.Apr 23 2019, 9:34 PM

This is a necessary patch.

If there is no file, it is returned from " if (! efl_file_loaded_get (obj)) "

This cause a compatibility issue.

Previously, if the file does not exist, it is newly created.

bu5hm4n requested changes to this revision.May 2 2019, 9:46 AM
bu5hm4n added a subscriber: bu5hm4n.

I am not sure about that. sd->file beeing != NULL does not imply that the content of the file is returned by elm_object_text_get. In which case do you hit the case where sd->file is != NULL but the file not loaded ?

This revision now requires changes to proceed.May 2 2019, 9:46 AM
akanad abandoned this revision.Sep 4 2019, 10:31 PM