Page MenuHomePhabricator

vg_common_json: Support mask with matte case.
ClosedPublic

Authored by jsuya on Apr 24 2019, 11:26 PM.

Details

Reviewers
Hermet
kimcinoo
Summary

The layer can have both a mask node and a matte node.
In this case, one of them may be missing because it uses one mask_set api.
If there is a matte, the mask is to be child of the matte.

Test Plan

.._mask_set(layer, matte);
.._mask_set(layer, mask);

Diff Detail

Repository
rEFL core/efl
Branch
devs/hermet/lottie
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11047
Build 8549: arc lint + arc unit
jsuya created this revision.Apr 24 2019, 11:26 PM
jsuya requested review of this revision.Apr 24 2019, 11:26 PM
Hermet requested changes to this revision.Apr 25 2019, 4:04 AM

please consider code consistency.

src/static_libs/vg_common/vg_common_json.c
264

See:
_construct_masks(Efl_Canvas_Vg_Container *mtarget, LOTMask *masks, unsigned int mask_cnt; int depth);

335

how about this pmask -> mtarget?

336

has_mask_layer -> mlayer (mask_layer)

This revision now requires changes to proceed.Apr 25 2019, 4:04 AM
jsuya marked 3 inline comments as done.Apr 25 2019, 5:56 PM
jsuya added inline comments.
src/static_libs/vg_common/vg_common_json.c
264

No problem. i wiil make patch soon.

jsuya updated this revision to Diff 21647.Apr 25 2019, 5:56 PM
jsuya marked an inline comment as done.

update commit

Hermet accepted this revision.Apr 25 2019, 6:45 PM
This revision is now accepted and ready to land.Apr 25 2019, 6:45 PM
Hermet closed this revision.Apr 25 2019, 6:52 PM