Page MenuHomePhabricator

ecore: add simple test for property_text_add.
Needs ReviewPublic

Authored by cedric on Sun, Apr 28, 11:05 AM.

Diff Detail

Repository
rEFL core/efl
Branch
T7832-devs/cedric/viewmodeltext
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11360
cedric created this revision.Sun, Apr 28, 11:05 AM
cedric requested review of this revision.Sun, Apr 28, 11:05 AM

Could the test also check that the returned string is the expected one? And check also invalid format strings, to make sure nothing breaks in the future? (I am thinking in degenerate strings like unterminated "%{", or invalid names "%{non-existing-name}")

Good point, will do.

cedric updated this revision to Diff 21852.Wed, May 1, 6:07 PM

Rebase and improve test to cover more case.

cedric updated this revision to Diff 21899.Thu, May 2, 9:42 AM

Rebase.

Should I use ${} instead of %{} ?

I don't think it matters much, unless we have other places inside EFL where we do such substitutions.

We might. Nothing exposed yet in the new API, but for path with eina_vpath we have (:something:) which I would add support for whatever we choose here. I would like something that people are used to and generally expect. which (:something:) is not.

cedric updated this revision to Diff 22091.Fri, May 10, 2:44 PM
cedric added a reviewer: raster.

Rebase and update test for the new syntax.