Depends on D8755
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could the test also check that the returned string is the expected one? And check also invalid format strings, to make sure nothing breaks in the future? (I am thinking in degenerate strings like unterminated "%{", or invalid names "%{non-existing-name}")
Comment Actions
I don't think it matters much, unless we have other places inside EFL where we do such substitutions.
Comment Actions
We might. Nothing exposed yet in the new API, but for path with eina_vpath we have (:something:) which I would add support for whatever we choose here. I would like something that people are used to and generally expect. which (:something:) is not.
Comment Actions
Hmmmm... in the docs we say that not_ready and on_error do not accept placeholder tags, but you are using them in the tests. Why?