Page MenuHomePhabricator

eldbus_test_eldbus_message: Fix resource leak
ClosedPublic

Authored by devilhorns on Apr 29 2019, 8:23 AM.

Details

Summary

Coverity reports that we leak the variable 'msg' going out of scope
here, so lets add a call to unref the returned eldbus_message so it
gets freed

Fixes CID1400921

@fix
Depends on D8772

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
devilhorns created this revision.Apr 29 2019, 8:23 AM
devilhorns requested review of this revision.Apr 29 2019, 8:23 AM
segfaultxavi accepted this revision.May 2 2019, 3:51 AM
segfaultxavi added a subscriber: segfaultxavi.

Builds, passes tests and makes sense.

(I don't know how this test works, though, since it is not asserting that the message iterator can be retrieved. Is it relying on console ERRs?)

This revision is now accepted and ready to land.May 2 2019, 3:51 AM
This revision was automatically updated to reflect the committed changes.