Page MenuHomePhabricator

eina_debug - fix init of cpu, bt and timer debug subsystems.
Needs RevisionPublic

Authored by NikaWhite on May 1 2019, 3:30 AM.

Details

Summary

Initialization of eina_debug_cpu, eina_debug_bt, eina_debug_timer
require active debug session that creates with eina_debug_local_connect.
Move back initialization of debug subsystems below the session
create. This commit revert changes from T7055.

Diff Detail

Repository
rEFL core/efl
Branch
eina_debug_fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11188
Build 8579: arc lint + arc unit
NikaWhite created this revision.May 1 2019, 3:30 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

NikaWhite requested review of this revision.May 1 2019, 3:30 AM

Mhm, this then again breaks BSD... @netstar, any other ideas for fixing the original issue ?

raster added a comment.May 2 2019, 9:00 AM

how doe sit break bsd?

This reverts your fix for T7055, which is a bsd bug, so i guess this will be back then ?!

raster added a comment.May 2 2019, 9:09 AM

move these just above the:

if (!getenv("EFL_NODEBUG") && !_debug_disabled)

but after the getuid/geteuid check... then it should be ok

raster added a comment.May 2 2019, 9:10 AM

@bu5hm4n thanks for pointing that out :)

bu5hm4n requested changes to this revision.May 2 2019, 9:12 AM

No Problem, i will request changes until this is done.

This revision now requires changes to proceed.May 2 2019, 9:12 AM

move these just above the:

if (!getenv("EFL_NODEBUG") && !_debug_disabled)

but after the getuid/geteuid check... then it should be ok

Actually we can't do this, because we need to establish connection before initialize eina_debug_* features. My knowledge is not enough to understand the root of the problem reported by @netstar . So if someone could explain what is wrong on bsd - I will try to find way around.

zmike added a subscriber: q66.May 2 2019, 11:00 AM

Maybe cc @q66, though I'm not sure we have anyone actively using/developing EFL on this platform anymore.