Page MenuHomePhabricator

elementary: move Fileselector to rely on Efl.FilterModel for filtering instead of custom logic.
ClosedPublic

Authored by cedric on May 1 2019, 11:08 AM.

Details

Summary

This simply a bit the logic of things, but more refactoring would be nice for this widget.

Depends on D8798

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.May 1 2019, 11:08 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.May 1 2019, 11:08 AM

I think code looks fine, but I found few preference coding styles,
I don't have strong opinion so if you thing current way is good then I'll be accept the patch.

src/lib/elementary/elc_fileselector.c
248

just preference.. but end is more proper then error to me...

253

just preference.. but end or clean up return is more proper then error to me as this code can be entered regardless of error.

266

I think negative return goes error is more natural.

275

same...

298

;

cedric added inline comments.May 9 2019, 8:33 AM
src/lib/elementary/elc_fileselector.c
248

It is not really an error, as the goal of check again is to know if you need to check the property again. It is only an error in the case of _fetch_bool_value which want to fetch a value now. I hope it makes sense.

cedric updated this revision to Diff 22064.May 9 2019, 9:20 AM
cedric edited the summary of this revision. (Show Details)

Rebase.

SanghyeonLee accepted this revision.May 9 2019, 11:48 PM

yeah as I told, this is just readability and preference problem so author think this is right, let's push it.

This revision is now accepted and ready to land.May 9 2019, 11:48 PM
This revision was automatically updated to reflect the committed changes.