Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/lib/eina/eina_slstr.h | ||
|---|---|---|
| 65 | Example method name does not match actual method name :D | |
Comment Actions
No further concerns. The code looks OK but this is the first time I come across eina short-lived strings so it'll be for the best if somebody else reviews it.
Comment Actions
I'd like to see explicit handling for a 0 length string (i.e., immediately return null).
Comment Actions
Actually this lead to ugly code. 0 length is not going to be returning null as by symmetry to strndup, we would only return NULL if the string is NULL. Otherwise we should return a valid empty string. So I don't think this is a good idea to implement. Leaning on strndup simplify the code and guarantee behavior to properly match user expectation.