Page MenuHomePhabricator

evas_object_textblock: Fix binary search fail.
ClosedPublic

Authored by lauromoura on May 2 2019, 12:25 AM.

Details

Summary

D8610 Makes API Testcase fault.

"&lt" is never searching.

@fix

Test Plan

char *markup = "<align=center>hello</align>>";
result = elm_entry_markup_to_utf8(markup);

The result should be "<align=center>hello</align>&gt;"

But the result was "align=center>hello/align>&gt;"

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
CHAN created this revision.May 2 2019, 12:25 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.May 2 2019, 12:25 AM
CHAN edited the summary of this revision. (Show Details)May 2 2019, 12:30 AM
CHAN edited the test plan for this revision. (Show Details)
CHAN added reviewers: ali.alzyod, Hermet.

Can you transform this test plan into a real testcase ?

lauromoura commandeered this revision.May 2 2019, 7:20 AM
lauromoura added a reviewer: CHAN.
lauromoura updated this revision to Diff 21890.May 2 2019, 7:34 AM
lauromoura edited the summary of this revision. (Show Details)
lauromoura edited the test plan for this revision. (Show Details)

Update with test and extra fix

lauromoura added inline comments.May 2 2019, 7:39 AM
src/lib/evas/canvas/evas_object_textblock.c
8189

I had to do this in order to correctly unescape apos.

It seems utf8_to_markup follows a completely different scheme from markup_to_utf8, avoiding the full escape scheme of D8610.

Shouldn't utf8_to_markup be changed to use it? @ali.alzyod @CHAN

bu5hm4n accepted this revision.May 2 2019, 9:04 AM

The question about utf8_to_markup can still be answered / done with this beeing merged.

Thank you @CHAN @lauromoura.

This revision is now accepted and ready to land.May 2 2019, 9:04 AM
Closed by commit rEFLfdfb781e22ba: evas_object_textblock: Fix binary search fail. (authored by Woochanlee <wc0917.lee@samsung.com>, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMay 2 2019, 9:15 AM
This revision was automatically updated to reflect the committed changes.
ali.alzyod added inline comments.May 7 2019, 1:55 AM
src/lib/evas/canvas/evas_object_textblock.c
8189

@lauromoura I think yes it should be updated, and cover all markups not just "dangerous" one.