Page MenuHomePhabricator
Differential D8811

cxx: Fix missing bits from header rename
ClosedPublic
Actions

Authored by lauromoura on May 2 2019, 2:47 PM.

Details

Reviewers
vtorri
vitor.sousa
felipealmeida
bu5hm4n
woohyun
Commits
rEFLc06486ca49d1: cxx: Fix missing bits from header rename

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.May 2 2019, 2:47 PM
lauromoura requested review of this revision.May 2 2019, 2:47 PM
vtorri accepted this revision.May 2 2019, 8:56 PM

compilation passes, now

This revision is now accepted and ready to land.May 2 2019, 8:56 PM
bu5hm4n requested changes to this revision.May 2 2019, 10:31 PM
bu5hm4n added inline comments.
src/lib/elementary/Efl_Ui.hh
0–1

This looks weird there should be another header define along this I think

This revision now requires changes to proceed.May 2 2019, 10:31 PM
This revision was not accepted when it landed; it landed in state Needs Revision.May 2 2019, 11:47 PM
Closed by commit rEFLc06486ca49d1: cxx: Fix missing bits from header rename (authored by lauromoura, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.
bu5hm4n added a comment.May 2 2019, 11:47 PM

I amended the changes i requested

Revision Contents
Changeset List

Diff 21910

View Options

src/Makefile_Cxx.am

Loading...
View Options

src/lib/elementary/Efl_Ui.hh

Loading...
View Options

src/tests/elementary/elm_cxx_suite.cc

Loading...