Page MenuHomePhabricator

replace strndup with eina_strndup, remove strndup definition in evil and elm_test_dnd
ClosedPublic

Authored by vtorri on May 3 2019, 2:17 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vtorri created this revision.May 3 2019, 2:17 AM
vtorri requested review of this revision.May 3 2019, 2:17 AM
raster requested changes to this revision.May 3 2019, 3:16 AM
raster added inline comments.
src/lib/eina/eina_slice.h
32

this creates all sorts of build failures due to const struct tm being unknown. we need more headers here to define this

This revision now requires changes to proceed.May 3 2019, 3:16 AM
vtorri added inline comments.May 3 2019, 3:27 AM
src/lib/eina/eina_slice.h
32

heh, then it was a bug before that commit , because indeed, struct tm is used in an API (eina_strftime), i'll fix that

vtorri added inline comments.May 3 2019, 4:27 AM
src/lib/eina/eina_slice.h
32

it's strange that on Windows, there is no problem. Maybe time.h is included by some header.

vtorri updated this revision to Diff 21915.May 3 2019, 4:29 AM
  • include time.h in eina_str.h, needed by struct tm
raster accepted this revision.May 3 2019, 5:13 AM

much better! :)

This revision is now accepted and ready to land.May 3 2019, 5:13 AM
This revision was automatically updated to reflect the committed changes.