Page MenuHomePhabricator
Differential D8817

pyolian: Fix tests
ClosedPublic
Actions

Authored by lauromoura on May 3 2019, 3:37 PM.

Details

Reviewers
bu5hm4n
DaveMDS
segfaultxavi
Commits
rEFL7927023fc7a3: pyolian: Fix tests
Summary

Update tests after some legacy cleanup from last release.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.May 3 2019, 3:37 PM
lauromoura requested review of this revision.May 3 2019, 3:37 PM
DaveMDS accepted this revision.May 5 2019, 7:34 AM

Seems good to me
Thanks for taking care :)

This revision is now accepted and ready to land.May 5 2019, 7:34 AM
bu5hm4n added a comment.May 5 2019, 7:45 AM

Should we add this as a running testsuite ?

DaveMDS added a comment.May 5 2019, 8:04 AM
In D8817#161153, @bu5hm4n wrote:

Should we add this as a running testsuite ?

Mhh, I don't think it's needed for now. Pyolian is just a dev tool and (for what I know) is not used for generating anything atm

segfaultxavi requested changes to this revision.Fri, Jul 26, 7:22 AM
segfaultxavi added a subscriber: segfaultxavi.

Does not apply anymore

This revision now requires changes to proceed.Fri, Jul 26, 7:22 AM
lauromoura updated this revision to Diff 23661.Fri, Jul 26, 12:37 PM

Rebase and update test after other files changed.

There is still one test failing due to an existing clash regarding Efl.Gfx.Image. It is both an Interface and a Namespace (for struct Stretch_Region).

This clash did not break C# as interfaces are prefixed with I.

segfaultxavi resigned from this revision.Mon, Jul 29, 3:39 AM

The clash regarding Efl.Gfx.Image should be gone now.

This revision is now accepted and ready to land.Mon, Jul 29, 3:39 AM
Closed by commit rEFL7927023fc7a3: pyolian: Fix tests (authored by lauromoura, committed by vitor.sousa). · Explain WhyMon, Jul 29, 7:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/scripts/pyolian/test_eolian.py (77 lines)

Diff 23700

View Options

src/scripts/pyolian/test_eolian.py

Loading...