Differential D8821

efl_ui_button: port to efl.ui.clickable
ClosedPublic
Actions

Authored by bu5hm4n on May 5 2019, 3:00 AM.

Tags

Subscribers

reviewers, committers

Details

Reviewers

zmike
segfaultxavi
cedric

Commits

rEFLbb1388798b1a: efl_ui_button: port to efl.ui.clickable

Summary

Depends on D8820

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.May 5 2019, 3:00 AM

Herald added a project: efl. · View Herald TranscriptMay 5 2019, 3:01 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.May 5 2019, 3:01 AM

bu5hm4n added a child revision: D8822: efl_test_clickable: introduce new tests.

Harbormaster completed remote builds in B11246: Diff 21934.May 5 2019, 3:03 AM

Makes sense, except for that inline comment.

src/lib/elementary/efl_ui_button.c
78	Shouldn't you emit the event just like in line 105 below?

This revision now requires changes to proceed.May 6 2019, 3:46 AM

Rebase & update according to xavi review

Harbormaster completed remote builds in B11265: Diff 21956.May 6 2019, 7:42 AM

bu5hm4n marked an inline comment as done.May 6 2019, 7:43 AM

bu5hm4n added inline comments.

src/lib/elementary/efl_ui_button.c
78	yep, thx

bu5hm4n marked 2 inline comments as done.May 6 2019, 7:43 AM

segfaultxavi accepted this revision.May 7 2019, 3:07 AM

This revision is now accepted and ready to land.May 7 2019, 3:07 AM

Rebase & update

Harbormaster completed remote builds in B11369: Diff 22103.May 12 2019, 2:17 AM

Make press,move-out-of-widget,unpress scenarios work

Harbormaster completed remote builds in B11396: Diff 22149.May 14 2019, 1:54 AM

Make press,move-out-of-widget,unpress scenarios work take 2

Harbormaster completed remote builds in B11401: Diff 22154.May 14 2019, 1:56 AM

update to new API names

Harbormaster completed remote builds in B11419: Diff 22174.May 14 2019, 10:53 AM

update to new API names, redo

Harbormaster completed remote builds in B11430: Diff 22185.May 14 2019, 11:22 AM

Closed by commit rEFLbb1388798b1a: efl_ui_button: port to efl.ui.clickable (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMay 14 2019, 1:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			data/elementary/themes/edc/efl/button.edc (8 lines)
M			src/lib/elementary/efl_ui_button.c (21 lines)

Diff 22197

data/elementary/themes/edc/efl/button.edc

Loading...

src/lib/elementary/efl_ui_button.c

Loading...