Page MenuHomePhabricator
Differential D8823

efl_ui_image: migrate to efl.ui.clickable
ClosedPublic
Actions

Authored by bu5hm4n on May 5 2019, 3:01 AM.

Details

Reviewers
zmike
segfaultxavi
cedric
Commits
rEFL8429ffba9caa: efl_ui_image: migrate to efl.ui.clickable
Summary

the mixin is now used to emit the events of the mixins. This is verified
by the testsuite. The testsuite needs a special treatment for the
object, because a missing image-file of the object would result in a 0x0
image size.

Depends on D8822

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.May 5 2019, 3:01 AM
bu5hm4n requested review of this revision.May 5 2019, 3:01 AM
bu5hm4n added a child revision: D8824: efl_ui_text: migrate to efl_ui_clickable.
segfaultxavi added a comment.May 6 2019, 3:57 AM

Makes sense but is there any way to verify this manually (besides the spec testsuite)? I cannot find any example using Efl.Ui.Image :(

bu5hm4n updated this revision to Diff 21958.May 6 2019, 7:41 AM
bu5hm4n edited the summary of this revision. (Show Details)

Rebase & update according to xavi review

bu5hm4n updated this revision to Diff 21980.May 6 2019, 8:16 AM

remove more code from image zoomable

bu5hm4n updated this revision to Diff 22105.May 12 2019, 2:17 AM

Rebase & update

bu5hm4n added a comment.May 12 2019, 2:25 AM

Okay, we cannot test zoomable right now. Zoomable is build in a way, that images are *sometimes* load with preload, which appear, to swallow and eat away the mouse events. However, for a user, this should not be a big problem, as this is a click which must have been within a few ms.

zmike accepted this revision.May 13 2019, 11:38 AM
This revision is now accepted and ready to land.May 13 2019, 11:38 AM
bu5hm4n updated this revision to Diff 22151.May 14 2019, 1:54 AM

Make press,move-out-of-widget,unpress scenarios work

bu5hm4n updated this revision to Diff 22156.May 14 2019, 1:55 AM

Make press,move-out-of-widget,unpress scenarios work take 2

bu5hm4n updated this revision to Diff 22176.May 14 2019, 10:53 AM

update to new API names

bu5hm4n updated this revision to Diff 22187.May 14 2019, 11:21 AM

update to new API names, redo

Closed by commit rEFL8429ffba9caa: efl_ui_image: migrate to efl.ui.clickable (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMay 14 2019, 1:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22200

View Options

src/lib/elementary/efl_ui_image.c

Loading...
View Options

src/lib/elementary/efl_ui_image_zoomable.c

Loading...
View Options

src/tests/elementary/spec/efl_test_clickable.c

Loading...