Details

Reviewers

zmike
segfaultxavi
cedric

Commits

rEFL6a5a5a430323: efl_ui: remove Efl.Ui.Clickable from containers

Summary

these widgets here are containers, means: they contain items that can be
clicked, but the container itself cannot be clicked. Later on, we should
introduce a new interface which contains events that reflect the clicked
event of theire items.

Depends on D8827

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.May 5 2019, 3:01 AM

Herald added a project: efl. · View Herald TranscriptMay 5 2019, 3:01 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.May 5 2019, 3:01 AM

Harbormaster completed remote builds in B11253: Diff 21941.May 5 2019, 3:04 AM

bu5hm4n added a child revision: D8829: efl_ui_item: protect against NULL access.May 5 2019, 3:05 AM

Rebase & update according to xavi review

Harbormaster completed remote builds in B11272: Diff 21963.May 6 2019, 7:42 AM

Add zoomable to tests, and publish the required rebase, sorry Xavi :|

Harbormaster completed remote builds in B11289: Diff 21996.May 7 2019, 2:54 AM

Add zoomable to tests, and publish the required rebase, sorry Xavi :|

Harbormaster completed remote builds in B11294: Diff 22002.May 7 2019, 2:56 AM

Rebase & update

Harbormaster completed remote builds in B11376: Diff 22110.May 12 2019, 2:18 AM

zmike accepted this revision.May 13 2019, 11:50 AM

This revision is now accepted and ready to land.May 13 2019, 11:50 AM

Make press,move-out-of-widget,unpress scenarios work take 2

Harbormaster completed remote builds in B11408: Diff 22161.May 14 2019, 1:56 AM

update to new API names

Harbormaster completed remote builds in B11426: Diff 22181.May 14 2019, 10:54 AM

update to new API names, redo

Harbormaster completed remote builds in B11437: Diff 22193.May 14 2019, 11:22 AM

Closed by commit rEFL6a5a5a430323: efl_ui: remove Efl.Ui.Clickable from containers (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMay 14 2019, 1:19 PM

This revision was automatically updated to reflect the committed changes.

zmike removed a child revision: D8829: efl_ui_item: protect against NULL access.May 15 2019, 6:09 AM

			Path	Packages
M			src/lib/elementary/efl_ui_grid.eo (1 line)
M			src/lib/elementary/efl_ui_list.eo (1 line)
M			src/lib/elementary/efl_ui_list_view.eo (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21941	3a15116		May 5 2019, 3:01 AM	★	★
Diff 2	21963	c368ecf	Rebase & update according to xavi review	May 6 2019, 7:41 AM	★	★
Diff 3	21996	ccf4d22	Add zoomable to tests, and publish the required rebase, sorry Xavi :\|	May 7 2019, 2:54 AM	★	★
Diff 4	22002	c686187	Add zoomable to tests, and publish the required rebase, sorry Xavi :\|	May 7 2019, 2:55 AM	★	★
Diff 5	22110	24fd4e9	Rebase & update	May 12 2019, 2:18 AM	★	★
Diff 6	22161	f1250b6	Make press,move-out-of-widget,unpress scenarios work take 2	May 14 2019, 1:55 AM	★	★
Diff 7	22181	0357dda	update to new API names	May 14 2019, 10:54 AM	★	★
Diff 8	22193	2e89bf2	update to new API names, redo	May 14 2019, 11:22 AM	★	★
Diff 9	22203	930f481	rEFL6a5a5a43032370acf9085c47a3627d4539ac324a	May 14 2019, 12:51 PM	★	★

efl_ui: remove Efl.Ui.Clickable from containers
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 22203

src/lib/elementary/efl_ui_grid.eo

src/lib/elementary/efl_ui_list.eo

src/lib/elementary/efl_ui_list_view.eo

efl_ui: remove Efl.Ui.Clickable from containersClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 22203

src/lib/elementary/efl_ui_grid.eo

src/lib/elementary/efl_ui_list.eo

src/lib/elementary/efl_ui_list_view.eo

efl_ui: remove Efl.Ui.Clickable from containers
ClosedPublic
Actions

Revision Contents
Changeset List