there's no point in allocating a massive mask surface if it's going to
be clipped to a smaller size, so instead just allocate the smaller size
and position it where the clipped size would be
this can only be enabled if the clipper is known to not be changing size,
as performance would be impacted if the clipper was forcing a full mask
redraw due to regular resizing
Depends on D8887
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Please check comment.
| src/lib/evas/canvas/evas_render.c | ||
|---|---|---|
| 1783–1784 | don't need to clip every time, but it could keep the clipped cache, so pass mask->cur->cache.clip.x, y, w, h, directly. | |
Considering caching behavior, this doesn't helpful because Clipping region could be adjustable.
If you draw only valid region, the mask image would be rendered several times whenever clip area is changed.
Does this patch really necessary?
If the clipping area is not changed frequently then this provides a massive performance boost.
I wonder if it would make sense to just use the direct clipper geometry for this and the related proxy sizing patch; the cases that these are being written for is when there is a static clipper applied to the proxy/mask which always causes them to be clipped to a smaller size.
In my experience, clipper size is frequently changed most cases. it's up to parent of the object.