Page MenuHomePhabricator

evas/scale_sample: further deduplicate masking code
ClosedPublic

Authored by zmike on May 7 2019, 11:06 AM.

Details

Summary

by adding a couple extra params to existing functions, we can reuse
existing code instead of copying it around and adding more bugs

no functional changes

Depends on D8846

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.May 7 2019, 11:06 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

segfaultxavi added inline comments.
src/lib/evas/common/evas_scale_sample.c
185–186

When srcptr != NULL we are calling func2 with an uninitialized buf array. Is this intended?

This is precisely the new usage you are introducing below.

zmike added inline comments.May 21 2019, 10:38 AM
src/lib/evas/common/evas_scale_sample.c
185–186

Good catch, I will check this...

zmike updated this revision to Diff 22303.May 21 2019, 10:47 AM
zmike edited the summary of this revision. (Show Details)

use same ptr in _evas_common_scale_rgba_sample_scale_mask funcs

zmike updated this revision to Diff 22304.May 21 2019, 11:09 AM

split func calls based on mul_col

segfaultxavi accepted this revision.May 21 2019, 11:14 AM

I see nothing suspicious now and the only test I could find still works, so...

This revision is now accepted and ready to land.May 21 2019, 11:14 AM
This revision was automatically updated to reflect the committed changes.