Page MenuHomePhabricator
Differential D8863

efl_pan: improve docs
ClosedPublic
Actions

Authored by segfaultxavi on May 8 2019, 8:07 AM.

Details

Reviewers
bu5hm4n
Commits
rEFL454b366fabcd: efl_pan: improve docs
rEFLf00e24de29a2: efl_pan: improve docs
Summary

documentation now reflects what is happening in the functions

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.May 8 2019, 8:07 AM
bu5hm4n requested review of this revision.May 8 2019, 8:07 AM
bu5hm4n added a child revision: D8864: efl_ui_pan: update to not use legacy API.
segfaultxavi added a comment.May 8 2019, 9:59 AM

Doing some tests to try to understand how this class actually works...

segfaultxavi commandeered this revision.Jul 30 2019, 3:17 AM
segfaultxavi edited reviewers, added: bu5hm4n; removed: segfaultxavi.
segfaultxavi updated this revision to Diff 23732.Jul 30 2019, 4:13 AM

Second round!

bu5hm4n added inline comments.Jul 30 2019, 10:30 AM
src/lib/elementary/efl_ui_pan.eo
17

I was also in this opinion. But when boncing is enabled, positions outside of min & max are possible, and should be supported. Sorry, i also got this wrong when writing this initial revision.

To be clear:
Min and Max only garantees that the content is fully visible, and no background is directly visible.

segfaultxavi updated this revision to Diff 23786.Jul 31 2019, 1:28 AM

Fix meaning of min and max positions.

bu5hm4n accepted this revision.Jul 31 2019, 1:47 AM
This revision is now accepted and ready to land.Jul 31 2019, 1:47 AM
Closed by commit rEFLf00e24de29a2: efl_pan: improve docs (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by segfaultxavi). · Explain WhyJul 31 2019, 1:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/elementary/efl_ui_pan.eo (48 lines)

Diff 23788

View Options

src/lib/elementary/efl_ui_pan.eo

Loading...