evas/render: fix proxy clipping when source_clip is disabled
Needs ReviewPublic
Actions

Authored by zmike on Fri, May 10, 11:39 AM.

Details

Reviewers

Summary

when source_clip is disabled, the clipper used should be the one used by
the proxy object. previously this would never be the case, meaning that
disabling source_clip had no effect

@fix
Depends on D8879

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 11355

zmike created this revision.Fri, May 10, 11:39 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald TranscriptFri, May 10, 11:39 AM

zmike requested review of this revision.Fri, May 10, 11:39 AM

zmike added a child revision: D8881: evas/render: size and draw proxy render surface based on proxy clipper.

Harbormaster completed remote builds in B11355: Diff 22086.Fri, May 10, 11:40 AM

Please check a comment.

src/lib/evas/canvas/evas_render.c
1655	Should we ignore Proxy object's clipper ? This seem bring different behavior. obj->cur->cache.clip.x must be applied with src_obj->cur->cache.clip.x;

This revision now requires changes to proceed.Mon, May 13, 1:37 AM

zmike requested review of this revision.Mon, May 13, 4:35 AM

zmike added inline comments.

src/lib/evas/canvas/evas_render.c
1655	No, this is the exact same behavior; the only difference here is that the clip geometry is being accessed through `proxy_render_data->src_obj` after this patch instead of through the passed `obj` parameter.

zmike removed a parent revision: D8879: evas/image: fix broken auto_fill mechanism when manually changing fill.Mon, May 13, 8:44 AM

Revision Contents
Changeset List

			Path	Packages
~			src/lib/evas/canvas/evas_render.c (19 lines)

Commit	Tree	Parents	Author	Summary	Date
3ffc3be207f0	3c803e631d14	16e4fed86a07	Mike Blumenkrantz	(Show More…)	Fri, May 10, 11:01 AM

Status	Author	Revision
Needs Review	zmike	D8888 mark clippers static in previous 3 tests
Needs Review	zmike	D8841 evas/render: clamp mask surface size to clipper size
Needs Review	zmike	D8881 evas/render: size and draw proxy render surface based on proxy clipper
Needs Review	zmike	D8880 evas/render: fix proxy clipping when source_clip is disabled
Needs Review	zmike	D8887 evas: add 'clipper_is_static' property for canvas objects

Diff 22086

View Options

src/lib/evas/canvas/evas_render.c

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22086	16e4fed		Fri, May 10, 11:39 AM	★	★