Page MenuHomePhabricator

meson: enforce 61s timeout for tests, remove explicit timeouts from build files
ClosedPublic

Authored by zmike on May 14 2019, 6:39 AM.

Details

Summary

unit tests automatically abort with info after 60s, and tests should be run with
an appropriate timeout to avoid conflict with the test runner's default 30s timeout

set explicit timeout in eio test for now because there's still frequent bugs here

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.May 14 2019, 6:39 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.May 14 2019, 6:39 AM
bu5hm4n requested changes to this revision.May 14 2019, 8:39 AM
bu5hm4n added a subscriber: bu5hm4n.

This misses a lot of testsuites. elementary for example.

This revision now requires changes to proceed.May 14 2019, 8:39 AM
zmike added a comment.May 14 2019, 9:26 AM

I'm now wondering whether it's worthwhile to explicitly set the timeouts in the build files. This seems like something which should be enforced by the test runner...

zmike updated this revision to Diff 22215.May 15 2019, 9:21 AM
zmike retitled this revision from meson: enforce 61s timeout for tests to meson: enforce 61s timeout for tests, remove explicit timeouts from build files.
zmike edited the summary of this revision. (Show Details)

Seems good, however, do you think we could run into issues where 61 sec. on CI will kill the effective process before the usefull output (the testcases still running) is printed ?

zmike added a comment.May 15 2019, 9:44 AM

Hm. My brain says no, but...

zmike updated this revision to Diff 22221.May 15 2019, 9:48 AM

make timeouts longer

bu5hm4n accepted this revision.May 15 2019, 9:48 AM
This revision is now accepted and ready to land.May 15 2019, 9:48 AM
Closed by commit rEFL7c7998b3dccc: meson: enforce 61s timeout for tests, remove explicit timeouts from build files (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMay 15 2019, 9:50 AM
This revision was automatically updated to reflect the committed changes.