Page MenuHomePhabricator

enlightenment_remote: bg-add break
Needs RevisionPublic

Authored by thierry1970 on May 15 2019, 2:35 AM.



It is no longer possible to change the wallpaper e19 with "enlightenment_remote".
The correction is a simple update of the code.

Diff Detail

rE core/enlightenment
No Linters Available
No Unit Test Coverage
Build Status
Buildable 11982
Build 8826: arc lint + arc unit
thierry1970 created this revision.May 15 2019, 2:35 AM
thierry1970 requested review of this revision.May 15 2019, 2:35 AM
devilhorns resigned from this revision.May 15 2019, 2:42 AM
devilhorns requested changes to this revision.Jun 26 2019, 11:07 AM
devilhorns added a subscriber: devilhorns.
devilhorns added inline comments.

These are all unused variables now so those should be removed from this function (zone, desk_x, desk_y).


These are all unused variables now so those should be removed from this function (zone, desk_x, desk_y).

This revision now requires changes to proceed.Jun 26 2019, 11:07 AM

Also, in data/tools/enlightenment_remote .. the help text for desktop-bg-add & desktop-bg-del still show container, zone, desk_x, desk_y as options to be passed in, so likely the help text should be updated also

thierry1970 marked 2 inline comments as done.
  • Removing unused variables (comment: devilhorns).
  • Removing unused variables (comment: devilhorns).
  • Updated help for options: desktop-bg-add and desktop-bg-del.

This looks good now. I will run a test with it tomorrow morning, and if everything is ok then I will push it to git master. Thank You :)

devilhorns resigned from this revision.Jun 27 2019, 6:09 AM

Ok so, I applied this patch and attempted to test it, however the background never changed when I executed the command so I cannot confirm that this patch actually works. I am going to see if @raster can take a look.

devilhorns edited reviewers, added: raster; removed: devilhorns.Jun 27 2019, 6:09 AM
thierry1970 added a comment.EditedJun 27 2019, 7:16 AM

Sorry, I tested with compatibility.
I have a clue error, I correct.

  • Update option index for desktop-bg-add.
raster requested changes to this revision.May 14 2020, 3:12 AM

ummm i can change bg. without this patch. this patch removes the ability to set a specific bg for a specific screen/desktop... so its all or nothing. this at least changes what this option does so any scripts depending on it break... :( and it doesn't fix anything i see. if you wanted a new option to set on all screens/desktops... then it should add a new option.

This revision now requires changes to proceed.May 14 2020, 3:12 AM