Page MenuHomePhabricator

Efl.Pack_Table: remove table_direction
ClosedPublic

Authored by segfaultxavi on Thu, May 16, 4:08 AM.

Details

Summary

The only implementation of this interface, Efl.Ui.Table, only supports two fill
directions (horizontal or vertical), therefore the table_direction property which
supports primary and secondary directions is unnecessarily complicated. Remove it
and use only Efl.Ui.Direction.direction to select the fill direction.
Also, expanded the documentation.

Fixes T7962

Test Plan

Everything builds and tests pass. Efl.Ui.Table elementary_test still work.
Examples need to be adjusted to stop using table_direction.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.Thu, May 16, 4:08 AM
segfaultxavi requested review of this revision.Thu, May 16, 4:08 AM

Typo in commit message.

segfaultxavi edited the summary of this revision. (Show Details)Thu, May 16, 4:11 AM
YOhoho accepted this revision.Mon, May 20, 1:32 AM

Thank you for the patch. looks good to me.

This revision is now accepted and ready to land.Mon, May 20, 1:32 AM
This revision was automatically updated to reflect the committed changes.