Page MenuHomePhabricator

efl_ui_navigation_bar: migrate to active_view
AbandonedPublic

Authored by bu5hm4n on May 19 2019, 4:00 AM.

Details

Summary

this also migrate the stack example, as this is the only user of those
two

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/work3
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11768
bu5hm4n created this revision.May 19 2019, 4:00 AM
bu5hm4n requested review of this revision.May 19 2019, 4:00 AM
bu5hm4n added a child revision: D8920: efl_ui_stack: remove!.
bu5hm4n updated this revision to Diff 22442.May 25 2019, 4:05 AM
bu5hm4n edited the summary of this revision. (Show Details)

use new API from stack

bu5hm4n updated this revision to Diff 22671.Jun 7 2019, 10:04 PM
bu5hm4n edited the summary of this revision. (Show Details)

implement active_unpack / active_pack

segfaultxavi added a comment.EditedJun 13 2019, 4:41 AM

Don't know if it's related, but before this patch when executing the Efl.Ui.Stack elm_test, if I press the Prev button right atfer starting the test, I get a crash with this message:

ERR<104521>:eina_safety ../src/lib/elementary/efl_ui_layout.c:958 _efl_ui_layout_base_efl_layout_signal_signal_emit() safety check failed: efl_invalidated_get(obj) is true

I cannot test this patch because the symbol efl_ui_active_view_active_index_deletion does not exist anymore.

Test with the other patch on top. that fixes everything, i think i should merge them into one.

I get the same crash after applying D8920 :(

zmike added a comment.Jun 13 2019, 9:50 AM

A couple points on the issues raised by @segfaultxavi:

  • it's not a crash, the test is intentionally written to close if the prev button is clicked from the first layout
  • this looks like a widget/clickable: the problem here is that the window is destroyed from the click callback out of clickable, but widget itself listens directly to evas mouse events (_obj_mouse_up) and then propagates focus from the widget class's mouse-up callback

So in either case it's not an issue with this patch.

OK, in that case, I have no comments regarding documentation, nomenclature or functionality, since tests seem to work correctly.
I am not reviewing the code, though.

bu5hm4n abandoned this revision.Jun 18 2019, 6:56 AM

This is now included in D8920