Page MenuHomePhabricator

terminology: call donecb later
ClosedPublic

Authored by bu5hm4n on May 21 2019, 12:04 PM.

Details

Summary

donecb must be called after the settings objects have been deleted.
Otherwise focus manager will detect that a focused object is deleted,
and performe recoverty things. Those recovery things end up in
terminology in focusing nothing, since the terminal object is not a
elementary widget. Not beeing a elementery widget here means that it is
not visible from the POV of the focus manager.

However, when we emit donecb later on, then the focus is restored (in
the callback) after focus manager has performed its voodoo.

This fixes focus disappearing after going into the settings and going
out of them again.

Diff Detail

Repository
rTRM apps/terminology
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n requested review of this revision.May 21 2019, 12:04 PM
bu5hm4n created this revision.
billiob accepted this revision.May 21 2019, 12:06 PM
This revision is now accepted and ready to land.May 21 2019, 12:06 PM
Closed by commit rTRM2168e6a85f22: terminology: call donecb later (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMay 21 2019, 12:08 PM
This revision was automatically updated to reflect the committed changes.