Page MenuHomePhabricator

evas vector: support json loader for rlottie integration.
ClosedPublic

Authored by Hermet on May 23 2019, 12:03 AM.

Details

Summary

Introduce a new evas json loader to support lottie animation.
This json loader uses rlottie library which is a new github open project.

These days most ui frameworks (windowpws, skia, qt, xamarin, react, nativescript) supports lottie,
the rlottie was designed to support lottie as a standalone library and compatible with efl as well.

To enable this,please install rlottie library then remove json disabler in meson_options.txt

For more information, See lottie/rlottie project and its a introdcution article:

https://airbnb.io/lottie/#/
https://github.com/samsung/rlottie
https://hermet.pe.kr/143

Co-authored-by: JunsuChoi <jsuya.choi@samsung.com>

D8941: evas vector: support lottie animation as using json loader.
D8944: evas vector: add a lottie animation example.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Hermet created this revision.May 23 2019, 12:03 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Hermet requested review of this revision.May 23 2019, 12:03 AM
Hermet updated this revision to Diff 22323.May 23 2019, 12:08 AM

added co-author info.

Hermet edited the summary of this revision. (Show Details)May 23 2019, 12:09 AM
bu5hm4n requested changes to this revision.Tue, May 28, 3:02 AM
bu5hm4n added a subscriber: bu5hm4n.

I only reviewed the meson parts, as i do not know the rest.

Can you also take git-phab the next time you propose a patchset ? Then automatically all parent revision links etc. are correctly displayed in the phabricator hirachy. Thank you :)

src/static_libs/vg_common/meson.build
13

We don't want to build support based on if something is installed or not, can you make this whole thing

if get_option('evas-loaders-disabler').contains('json') == false
   *everything does here*
endif

With this we prevent that we have different build results based on installed dependencies.

This revision now requires changes to proceed.Tue, May 28, 3:02 AM
Hermet updated this revision to Diff 22470.Tue, May 28, 3:48 AM
Hermet edited the summary of this revision. (Show Details)

updated as reviewers' comment.

Hermet edited the summary of this revision. (Show Details)Tue, May 28, 3:51 AM
Hermet edited the summary of this revision. (Show Details)
bu5hm4n resigned from this revision.Tue, May 28, 12:48 PM

meson looks good to me :)

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 21, 1:36 AM
This revision was automatically updated to reflect the committed changes.