Page MenuHomePhabricator

Genlist: Fix for genlist item field update
ClosedPublic

Authored by godlytalias on May 24 2019, 4:44 AM.

Details

Summary

Avoid unnecessary operations on unrealized item when item field update is called

Test Plan

Call item_field_update on an unrealized item

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
godlytalias created this revision.May 24 2019, 4:44 AM
godlytalias requested review of this revision.May 24 2019, 4:44 AM

hmm I agreed basic idea of this patch....
one my concern is when item size need to be updated by text / content changes...
i'll do few test with this patch and review it again.

@SanghyeonLee Any changes needed for this patch? Should we mark item for update even in text update? Only in case of multiline text items we may have to do item update on a text update

SanghyeonLee accepted this revision.May 29 2019, 11:45 PM

I've tested few cases that I worried about,
but looks okay with it.
thanks for the work :)

This revision is now accepted and ready to land.May 29 2019, 11:45 PM
This revision was automatically updated to reflect the committed changes.